Fix length when getting property from host #123774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
elinor-fung
added
area-Host
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect SString length handling when reading runtime properties from the host by aligning buffer open/close semantics with the host contract’s “length includes null terminator” behavior.
Changes:
- Adjusts
OpenUTF8Buffersizing to account forSString’s implicit null terminator space. - Uses
CloseBuffer(finalCount)with the actual number of bytes written (excluding the null terminator). - Adds tighter failure handling for invalid/failed host property reads.
elinor-fung
force-pushed
the
host-prop-len
branch
from
3795252 to
b5074f1
Compare
AaronRobinsonMSFT
approved these changes
Jan 29, 2026
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
One nit. Other than that, nice job tracking this mess down.
agocke
approved these changes
Jan 30, 2026
This was referenced Jan 30, 2026
Member
Author
|
/ba-g unrelated timeout in win-arm64 NativeAOT legs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting a property from the host, we'd end up with a string length that was greater than the actual property length. Close the buffer with the actual length written.
cc @dotnet/appmodel @AaronRobinsonMSFT